Attention is currently required from: Arthur Heymans, Benjamin Doron, Lance Zhao, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75685?usp=email )
Change subject: WIP acpi: Add SPCR table
......................................................................
Patch Set 3:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/75685/comment/78c08d6c_ccaa9814 :
PS3, Line 1842: /* 16550 compatible, TODO do we need others? */
Maybe:
```
if (!CONFIG(CONSOLE_SERIAL))
return;
```
https://review.coreboot.org/c/coreboot/+/75685/comment/627b025a_7d63553b :
PS3, Line 1870: /* TODO: provide callback for IRQ on non standard ports*/
Would it be bad not to use an IRQ at all?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75685?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64e624c17a27b9215a8ba83bd6cbb2c0a7aa1dfc
Gerrit-Change-Number: 75685
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 07 Jun 2023 12:42:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment