Attention is currently required from: Alicja Michalska.
Angel Pons has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/84175?usp=email )
Change subject: mb/topton/adl: Add initial support for X2F N100 FW appliance ......................................................................
Patch Set 9: Code-Review+1
(2 comments)
File src/mainboard/topton/adl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/84175/comment/cf7c5095_59bdea96?usp... : PS2, Line 43: # TODO: SATA doesn't work. EDK2 returns "Unsupported", not sure how to fix (yet).
Yes, I know. I tried setting it, but it didn't work. […]
I meant these:
``` register "sata_ports_enable" = "{ [0] = 1, [1] = 1, }" ``` I forget how many SATA ports ADL-N has, though. Also, it could be like the ODROID and use a PCIe-to-SATA controller, did you check that?
File src/mainboard/topton/adl/mainboard.c:
https://review.coreboot.org/c/coreboot/+/84175/comment/d123e358_d33257b3?usp... : PS9, Line 17: params->PchLegacyIoLowLatency = 1; I think I commented on what this was, could you please add a comment so that I don't ask over and over? :D