Change in coreboot[master]: mb/google/poppy/variants/nocturne: configure the FPMCU interface
30 May
2018
30 May
'18
5:35 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26684 )
Change subject: mb/google/poppy/variants/nocturne: configure the FPMCU interface ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants/... PS1, Line 136: 1 I had missed this on the other CL. This should be 0 since ACPI power resource will take care of de-asserting reset.
--
To view, visit https://review.coreboot.org/26684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417dcf84cda8e354060785cd16a7b6b812148d5
Gerrit-Change-Number: 26684
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Palatin vpalatin@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Wed, 30 May 2018 11:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
2541
days inactive
2541
days old
0 comments
1 participants
participants (1)
-
Furquan Shaikh (Code Review)