Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62330 )
Change subject: mb/google/brya: Add companion device name to WWAN PCIe generic device
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62330/comment/1b4ecdda_9e54f914
PS10, Line 213: rp6_wwan
do you mean that PCI generic is no need at all in the device tree since wwan provides _DSD? we can r […]
We are supposed to have the DmaProperty in 3 places total:
1) CNVi device - https://review.coreboot.org/c/coreboot/+/61385
2) WWAN device (PXSX) - https://review.coreboot.org/c/coreboot/+/62436/4
3) PCIe RP of the WWAN device (_SB.PCI0.RP06) - what this is one is supposed to be doing
actually is the companion device even necessary? did I just get myself all tangled up in ACPI devices?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 10
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Comment-Date: Fri, 11 Mar 2022 03:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment