Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49103 )
Change subject: mb/intel/jasperlake_rvp: Fix building with CONFIG_CHROMEOS unset ......................................................................
mb/intel/jasperlake_rvp: Fix building with CONFIG_CHROMEOS unset
Make EC_GOOGLE_CHROMEEC_SWITCHES depend on VBOOT, rather than force selecting it.
Change-Id: If96b2a935d2f7388a24be7d8e65c7dfc2c89a0fc Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/intel/jasperlake_rvp/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/49103/1
diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig.name b/src/mainboard/intel/jasperlake_rvp/Kconfig.name index 5c7a007..68419ac 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig.name +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig.name @@ -7,5 +7,5 @@ bool "Jasperlake DDR4/LPDDR4 RVP with Chrome EC" select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC - select EC_GOOGLE_CHROMEEC_SWITCHES + select EC_GOOGLE_CHROMEEC_SWITCHES if VBOOT select INTEL_LPSS_UART_FOR_CONSOLE
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49103 )
Change subject: mb/intel/jasperlake_rvp: Fix building with CONFIG_CHROMEOS unset ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49103 )
Change subject: mb/intel/jasperlake_rvp: Fix building with CONFIG_CHROMEOS unset ......................................................................
mb/intel/jasperlake_rvp: Fix building with CONFIG_CHROMEOS unset
Make EC_GOOGLE_CHROMEEC_SWITCHES depend on VBOOT, rather than force selecting it.
Change-Id: If96b2a935d2f7388a24be7d8e65c7dfc2c89a0fc Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49103 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/intel/jasperlake_rvp/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig.name b/src/mainboard/intel/jasperlake_rvp/Kconfig.name index 5c7a007..68419ac 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig.name +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig.name @@ -7,5 +7,5 @@ bool "Jasperlake DDR4/LPDDR4 RVP with Chrome EC" select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC - select EC_GOOGLE_CHROMEEC_SWITCHES + select EC_GOOGLE_CHROMEEC_SWITCHES if VBOOT select INTEL_LPSS_UART_FOR_CONSOLE