Attention is currently required from: Jérémy Compostella, Maximilian Brune.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86580?usp=email )
Change subject: cpu/x86/64bit: Allow to map more of the address space
......................................................................
Patch Set 2:
(2 comments)
File src/cpu/x86/64bit/pt1G.S:
https://review.coreboot.org/c/coreboot/+/86580/comment/b9d76cc2_581bc72a?usp... :
PS1, Line 23: .rept (CONFIG_CPU_PT_ROM_MAP_GB + 511) / 512
Thats what I was trying to say. We agree on that. […]
Done
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/86580/comment/50a020b1_6559fe67?usp... :
PS1, Line 165: default 512 if !NEED_SMALL_2MB_PAGE_TABLES
Is it necessary to specify `if !NEED_SMALL_2MB_PAGE_TABLES` considering this is the opposite of the […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86580?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If669426f2b5ae40dd5c62e17f3a0234783b7d462
Gerrit-Change-Number: 86580
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 11:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com