Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83147?usp=email )
Change subject: mb/google/brox/var/lotso: GPP_B14 used for buzzer ......................................................................
mb/google/brox/var/lotso: GPP_B14 used for buzzer
ALC257 does not supoort built-in digtal buzzer, So use external pwm to PCBEEP for beep sound.
BUG=b:346956771 BRANCH=None TEST=emerge-brox coreboot sys-boot/chromeos-bootimage
firmware-shell: devbeep -> can output beep normally.
Change-Id: If924f9f27f229420e78015f418a97b2d5daf62e5 Signed-off-by: Jing Tong tongjian@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83147 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wentao Qin qinwentao@huaqin.corp-partner.google.com Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/brox/variants/lotso/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: Karthik Ramasubramanian: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Wentao Qin: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brox/variants/lotso/gpio.c b/src/mainboard/google/brox/variants/lotso/gpio.c index 230ecaf..c85363d 100644 --- a/src/mainboard/google/brox/variants/lotso/gpio.c +++ b/src/mainboard/google/brox/variants/lotso/gpio.c @@ -7,6 +7,9 @@
/* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { + /* GPP_B14 : [NF1: SPKR NF2: TIME_SYNC1 NF4: SATA_LED# NF5: ISH_GP6 + * NF6: USB_C_GPP_B14] ==> ACZ_SPKR */ + PAD_CFG_NF(GPP_B14, NONE, DEEP, NF1), /* GPP_D5 : SRCCLKREQ0_L ==> PCIE_REFCLK_SSD1_REQ_N */ PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* GPP_D6 : [NF1: SRCCLKREQ1# NF6: USB_C_GPP_D6] ==> SOC_GPP_E10 (NC) */