Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49066 )
Change subject: nb/intel/sandybridge: Use consistent comment style ......................................................................
nb/intel/sandybridge: Use consistent comment style
Change-Id: Iacb1fb0a1309c3c23e670fee540514b6f546314a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/49066/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index cef104c..eac0b50 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -430,7 +430,7 @@ remaplimit = remapbase + MIN(4096, tom - me_uma_size) - toludbase - 1; touudbase = remaplimit + 1; } else { - // Reclaim not possible + /* Reclaim not possible */ reclaim = 0; touudbase = tom - me_uma_size; } @@ -752,11 +752,11 @@ { switch (odt) { case 30: - return (1 << 9) | (1 << 2); // RZQ/8, RZQ/4 + return (1 << 9) | (1 << 2); /* RZQ/8, RZQ/4 */ case 60: - return (1 << 2); // RZQ/4 + return (1 << 2); /* RZQ/4 */ case 120: - return (1 << 6); // RZQ/2 + return (1 << 6); /* RZQ/2 */ default: case 0: return 0; @@ -2827,8 +2827,8 @@ FOR_ALL_CHANNELS MCHBAR32(PM_TRML_M_CONFIG_ch(channel)) = 0x00000aaa;
- MCHBAR32(PM_BW_LIMIT_CONFIG) = 0x5f7003ff; // OK - MCHBAR32(PM_DLL_CONFIG) = 0x00073000 | ctrl->mdll_wake_delay; // OK + MCHBAR32(PM_BW_LIMIT_CONFIG) = 0x5f7003ff; + MCHBAR32(PM_DLL_CONFIG) = 0x00073000 | ctrl->mdll_wake_delay;
FOR_ALL_CHANNELS { switch (ctrl->rankmap[channel]) {
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49066 )
Change subject: nb/intel/sandybridge: Use consistent comment style ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49066 )
Change subject: nb/intel/sandybridge: Use consistent comment style ......................................................................
nb/intel/sandybridge: Use consistent comment style
Change-Id: Iacb1fb0a1309c3c23e670fee540514b6f546314a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49066 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index cef104c..eac0b50 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -430,7 +430,7 @@ remaplimit = remapbase + MIN(4096, tom - me_uma_size) - toludbase - 1; touudbase = remaplimit + 1; } else { - // Reclaim not possible + /* Reclaim not possible */ reclaim = 0; touudbase = tom - me_uma_size; } @@ -752,11 +752,11 @@ { switch (odt) { case 30: - return (1 << 9) | (1 << 2); // RZQ/8, RZQ/4 + return (1 << 9) | (1 << 2); /* RZQ/8, RZQ/4 */ case 60: - return (1 << 2); // RZQ/4 + return (1 << 2); /* RZQ/4 */ case 120: - return (1 << 6); // RZQ/2 + return (1 << 6); /* RZQ/2 */ default: case 0: return 0; @@ -2827,8 +2827,8 @@ FOR_ALL_CHANNELS MCHBAR32(PM_TRML_M_CONFIG_ch(channel)) = 0x00000aaa;
- MCHBAR32(PM_BW_LIMIT_CONFIG) = 0x5f7003ff; // OK - MCHBAR32(PM_DLL_CONFIG) = 0x00073000 | ctrl->mdll_wake_delay; // OK + MCHBAR32(PM_BW_LIMIT_CONFIG) = 0x5f7003ff; + MCHBAR32(PM_DLL_CONFIG) = 0x00073000 | ctrl->mdll_wake_delay;
FOR_ALL_CHANNELS { switch (ctrl->rankmap[channel]) {