Attention is currently required from: Lance Zhao, Furquan Shaikh, Subrata Banik, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50297 )
Change subject: soc/intel: Drop CID1 from GNVS
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/nvs.h:
https://review.coreboot.org/c/coreboot/+/50297/comment/90c7c006_08d0ed83
PS2, Line 23: unused_was_cid1
But the structure is defined and used within coreboot, there's no 3rdparty dependency. […]
And once you notice the offsets appear in the comments, the workload just explodes. About half of the GNVS is still nonsense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09ea756fb3743e33d1e221f0a0df3a6fdc3fc3ba
Gerrit-Change-Number: 50297
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 08 Feb 2021 04:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment