Attention is currently required from: Marx Wang, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Balaji Manigandan, Nick Vaccaro, Patrick Rudolph.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )
Change subject: soc/intel/common Add support for CSE IOM/NPHY sub-parition update
......................................................................
Patch Set 11:
(3 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59685/comment/919bdfc7_a8c7b394
PS11, Line 888: cbfs_locate_file_in_region
should now be `cbfs_locate_file_in_region`
Looks like this API is getting deprecated. Need to identify another API to get access to cbfs file in the region_device.
https://review.coreboot.org/c/coreboot/+/59685/comment/745fc33b_24f35c88
PS11, Line 958: /* Get sub-partition blob's version */
Should these blobs have a hash stored in FW_MAIN_A/FW_MAIN_B/COREBOOT, just like the me_rw hash (and […]
These blobs are part of FW_MAIN_A/FW_MAIN_B/COREBOOT, they are verified by vboot.
https://review.coreboot.org/c/coreboot/+/59685/comment/269aad06_5fc6bb25
PS11, Line 1035: void cse_fw_sync(void)
Since the mainboard is the entity with the knowledge of whether or not an update is ultimately requi […]
cse_fw_sync() is being called from SoC romstage.c, but getting enabled from mainboard Kconfig.
In the current scenario, IOM/NPHY update is specific to SoC.
`is_cse_sub_part_update_req` should be determined by SoC, while Kconfig to enable this feature comes from mainboard. Your thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c0cda51314c4f722f5432486a43e19b46f4b240
Gerrit-Change-Number: 59685
Gerrit-PatchSet: 11
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: Marx Wang
marx.wang@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 01 Dec 2021 06:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment