Change in coreboot[master]: mb/google/kohaku: Use level trigger for touchscreen interrupt
Hello Seunghwan Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34898
to review the following change.
Change subject: mb/google/kohaku: Use level trigger for touchscreen interrupt ......................................................................
mb/google/kohaku: Use level trigger for touchscreen interrupt
Level trigger is recommended setting for touchscreen interrupt of kohaku, so we would change it as the recommedation.
BUG=b:139179200 BRANCH=none TEST=Verified pen works on kohaku
Change-Id: Ibbcdbe3ab555d014048f66ff527e539c5b566187 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/34898/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 1d4c1c3..9e33bac 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -89,7 +89,7 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""atmel,maxtouch"" register "desc" = ""Atmel Touchscreen"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D16_IRQ)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" register "reset_delay_ms" = "91" # 90.5 ms register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C12)"
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34898 )
Change subject: mb/google/kohaku: Use level trigger for touchscreen interrupt ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG@14 PS1, Line 14: pen I am confused. Shouldn't you be testing touchscreen?
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34898 )
Change subject: mb/google/kohaku: Use level trigger for touchscreen interrupt ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG@14 PS1, Line 14: pen
I am confused. […]
Oh, Jongpil tested it on EVT board in factory. He didn't update comment about it yet into issue tracker, but confirmed touchscreen works well and asked me to upload this CL.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34898 )
Change subject: mb/google/kohaku: Use level trigger for touchscreen interrupt ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG@14 PS1, Line 14: pen
Oh, Jongpil tested it on EVT board in factory. […]
Can you please update the commit message to indicate that touchscreen was tested and it works.
SH Kim has uploaded a new patch set (#2) to the change originally created by shkim. ( https://review.coreboot.org/c/coreboot/+/34898 )
Change subject: mb/google/kohaku: Use level trigger for touchscreen interrupt ......................................................................
mb/google/kohaku: Use level trigger for touchscreen interrupt
Level trigger is recommended setting for touchscreen interrupt of kohaku, so we would change it as the recommedation.
BUG=b:139179200 BRANCH=none TEST=Verified touchscreen works on kohaku
Change-Id: Ibbcdbe3ab555d014048f66ff527e539c5b566187 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/34898/2
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34898 )
Change subject: mb/google/kohaku: Use level trigger for touchscreen interrupt ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34898/1//COMMIT_MSG@14 PS1, Line 14: pen
Can you please update the commit message to indicate that touchscreen was tested and it works.
Ah!!!! Sorry. Just modified it.
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34898 )
Change subject: mb/google/kohaku: Use level trigger for touchscreen interrupt ......................................................................
mb/google/kohaku: Use level trigger for touchscreen interrupt
Level trigger is recommended setting for touchscreen interrupt of kohaku, so we would change it as the recommedation.
BUG=b:139179200 BRANCH=none TEST=Verified touchscreen works on kohaku
Change-Id: Ibbcdbe3ab555d014048f66ff527e539c5b566187 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34898 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 1d4c1c3..9e33bac 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -89,7 +89,7 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""atmel,maxtouch"" register "desc" = ""Atmel Touchscreen"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D16_IRQ)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" register "reset_delay_ms" = "91" # 90.5 ms register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C12)"
-
Furquan Shaikh (Code Review) -
SH Kim (Code Review)
-
shkim (Code Review)