Robert Reeves has posted comments on this change. ( https://review.coreboot.org/23651 )
Change subject: mainboard/hp: Add HP Elitebook 8770w ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/cmos.layout File src/mainboard/hp/8770w/cmos.layout:
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/cmos.layout@9... PS1, Line 91: 6 0 Emergency : 6 1 Alert : 6 2 Critical : 6 3 Error : 6 4 Warning : 6 5 Notice : 6 6 Info : 6 7 Debug : 6 8 Spew Applied the change recommended by Arthur Heymans on the previous version of this submission. Funnily enough, I had never changed this to begin with, that was just how it was on the original file when I started this port in December.
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/romstage.c File src/mainboard/hp/8770w/romstage.c:
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/romstage.c@42 PS1, Line 42: { : } Got rid of the whitespace here.
-
Robert Reeves (Code Review)