Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeff Daly, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Sean Rhodes, Subrata Banik, Tarun, Vanessa Eusebio, Werner Zeh.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83065?usp=email )
Change subject: cpu/x86: Select proper SMM save Kconfig option
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
Where is this usually documented?
It seems selecting from the sockets is unnecessary, as we want the disjunction
of what the selected CPUs select?
File src/cpu/intel/model_106cx/Kconfig:
https://review.coreboot.org/c/coreboot/+/83065/comment/20fca732_2ee1e960?usp... :
PS4, Line 16: select X86_EM64T101_SAVE_STATE
Is this right? legacy + 101? feels like one could fall into the gap...
File src/cpu/intel/model_f2x/Kconfig:
https://review.coreboot.org/c/coreboot/+/83065/comment/e2fa653a_e9e68155?usp... :
PS4, Line 10: select X86_EM64T101_SAVE_STATE
According to Wikipedia, 64-bit support started with Prescott (f3x):
https://en.wikipedia.org/wiki/List_of_Intel_Pentium_4_processors#Prescott_(9...
I guess it doesn't matter if they share the socket...
Again I'm surprised to see em64t10*1*
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83065?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If045a04b6617eefc79a117486a9b224f4ca96b17
Gerrit-Change-Number: 83065
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Sun, 16 Jun 2024 12:42:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No