Change in coreboot[master]: soc/intel: Remove SMM HECI disable related options - coreboot-gerrit

9 Apr 2021


      Attention is currently required from: Martin Roth, Furquan Shaikh, Aaron Durbin, Karthik Ramasubramanian.
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 )
Change subject: soc/intel: Remove SMM HECI disable related options
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/cannonlake/smihandler.c:
https://review.coreboot.org/c/coreboot/+/52147/comment/4fe93a31_fd6ed612 
PS2, Line 22: 	const struct device *dev = pcidev_path_on_root(PCH_DEVFN_CSE);
            : 	if (!is_dev_enabled(dev))
CNL doesn't consult the devicetree here. Is this check sufficient?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52147
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92
Gerrit-Change-Number: 52147
Gerrit-PatchSet: 2
Gerrit-Owner: Aseda Aboagye aaboagye@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Aaron Durbin adurbin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 22:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment