Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81676?usp=email )
Change subject: mb/google/brya: Remove baseboard-specific FMD names
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81676/comment/2046abbf_99b3d89a :
PS2, Line 11: Additionally, this patch removes the Nissa-specific
: 32MB FMD file, as the Nissa board only uses a 16MB SPI flash.
i guess you said that some Nissa variant also uses 32MB fmd file ? so, better we call out here that this CL attempts to unify 32MB FMD between brya and nissa variants.
Also, please test the 32MB unified FMD booting for Nivviks.
https://review.coreboot.org/c/coreboot/+/81676/comment/7d88b919_e8e8942f :
PS2, Line 14:
please create a bug id for trulo baseboard support and use that here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81676?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9151a4bcbe9cc084cc19b1a3e91c0321fe4dcc37
Gerrit-Change-Number: 81676
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sun, 07 Apr 2024 04:43:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment