Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59843 )
Change subject: libpayload/Makefile: Improve object files list creation
......................................................................
Patch Set 2:
(1 comment)
File payloads/libpayload/Makefile:
https://review.coreboot.org/c/coreboot/+/59843/comment/f1de06b8_3c39f512
PS1, Line 322: # $1 lib name
Are you sure, we should change it? coreboot has stages after all, and libpayload does have libs. […]
It's also called "class" in line 329 here. The advantage of sticking to the generic name would be that we could synchronize the two copies every now and then.
On the other hand: maybe they already diverged enough to be separate entities by now, not sure. In any case, as mentioned that would be a follow up, so resolving this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59843
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1280c0a3f7e99aad2ecf8a0379a98af31ccefc3
Gerrit-Change-Number: 59843
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Mon, 06 Dec 2021 15:38:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment