Change in coreboot[master]: abuild: Treat command line for recursive invocations as bash...
Julius Werner has posted comments on this change. ( https://review.coreboot.org/18975 )
Change subject: abuild: Treat command line for recursive invocations as bash array ......................................................................
Patch Set 3:
(3 comments)
Yes, -t "vendor/board1 vendor/board2" doesn't work, but -t "VENDOR_BOARD1 VENDOR_BOARD2" (the Kconfig names) does. That was good enough for me for now.
https://review.coreboot.org/#/c/18975/3/util/abuild/abuild File util/abuild/abuild:
PS3, Line 19: ABUILD_DATE="Dec 6, 2016" : ABUILD_VERSION="0.10.01"
Do you think this change is worth updating the version and date?
Sure, why not...
PS3, Line 784: local num_targets=$(wc -w <<<$targets)
From shellcheck
Done
PS3, Line 785: local cpus_per_target=$(((${cpus:-1} + $num_targets - 1) / $num_targets))
From shellcheck:
Fixed, and ran shellcheck myself to confirm. Also noticed I can actually take out the warning disable down there now, since $cmdline is now passed with quotes.
-
Julius Werner (Code Review)