Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50492 )
Change subject: soc/amd/common/block/acpi/pm_state: don't rely on undefined behavior ......................................................................
soc/amd/common/block/acpi/pm_state: don't rely on undefined behavior
Change-Id: I5a76a38f8d84666f6b9c0bfffecca064fa82d593 Found-by: Coverity CID 1445994 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/acpi/pm_state.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/50492/1
diff --git a/src/soc/amd/common/block/acpi/pm_state.c b/src/soc/amd/common/block/acpi/pm_state.c index ea22ec5..643cb02 100644 --- a/src/soc/amd/common/block/acpi/pm_state.c +++ b/src/soc/amd/common/block/acpi/pm_state.c @@ -18,7 +18,7 @@ return -1;
/* get a mask of valid bits. Ex limit = 3, set bits 0-2 */ - t = (1 << limit) - 1; + t = (1ULL << limit) - 1; if ((value & t) == 0) return -1; t = 1;