Attention is currently required from: Hung-Te Lin, Jarried Lin, Xinxiong Xu, Yang Wu, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85858?usp=email )
Change subject: mb/google/rauru: Add alc5650 support
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85858/comment/43a57153_90ec33e7?usp... :
PS2, Line 21: i2s
Could you also send a separate patch and rename this to `configure_tas2563` ?
https://review.coreboot.org/c/coreboot/+/85858/comment/51220e3f_9a2f8a1b?usp... :
PS2, Line 52: printk(BIOS_INFO, "Audio configure ALC5645\n");
What about moving this log to `configure_alc5645` ?
```
printk(BIOS_INFO, "%s: done\n");
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85858?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2c247be87ad212fa52e21e1e6da17c07d82f1988
Gerrit-Change-Number: 85858
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 06 Jan 2025 05:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No