Attention is currently required from: Martin L Roth, Maximilian Brune, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76689?usp=email )
Change subject: soc/sifive/fu740: Add FU740 SOC
......................................................................
Patch Set 13: Code-Review+2
(2 comments)
File src/soc/sifive/fu740/cbmem.c:
https://review.coreboot.org/c/coreboot/+/76689/comment/915e84ef_6fe1b34b :
PS12, Line 11: #define FU740_MAXDRAM 0x800000000ULL // 32 GiB
I only put it in here to emphasis it is only used here and for all other operations `sdram_size()` i […]
Acknowledged
File src/soc/sifive/fu740/spi_internal.h:
https://review.coreboot.org/c/coreboot/+/76689/comment/ebbb8984_9a384b75 :
PS12, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
This file contains the SPI stuff that is not needed outside of the SOC code. `include/soc/spi. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76689?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a8fe02ef0adcb939aa65377a35874715c5ee58a
Gerrit-Change-Number: 76689
Gerrit-PatchSet: 13
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Jan Samek
jan.samek@siemens.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Marvin Drees
marvin.drees@9elements.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Sun, 03 Mar 2024 21:19:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment