Change in coreboot[master]: soc/intel/elkhartlake: Expose FIVR config to mainboard

[Lean Sheng Tan (Code Review)]

Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55861 )

Change subject: soc/intel/elkhartlake: Expose FIVR config to mainboard
......................................................................

Patch Set 4:

(3 comments)

File src/soc/intel/elkhartlake/chip.h:

https://review.coreboot.org/c/coreboot/+/55861/comment/d70666df_e3dc60e9 
PS3, Line 77:
> I would align FIVR_VOLTAGE_MIN_RETENTION with FIVR_VOLTAGE_NORMAL as it belongs to the same bitmask.

Done

https://review.coreboot.org/c/coreboot/+/55861/comment/2c268eb6_86e2cb2c 
PS3, Line 382: 	enum fivr_states v1p05_state_bitmap;
             : 		enum fivr_states vnn_state_bitmap;
             : 		enum fivr_states vnn_sx_state_bitmap;
             : 		enum fivr_supported_voltage v1p05_volt_bitmap;
             : 		enum fivr_supported_voltage vnn_volt_bitmap;
> Is there any benefit in calling all the members *_bitmap? The type is clear with the enum, so why no […]

Done

https://review.coreboot.org/c/coreboot/+/55861/comment/5a9dd731_7f63a8a4 
PS3, Line 393: unsigned int vcc_low_high_usec;
             : 		/* From retention mode voltage to high current mode voltage */
             : 		unsigned int vcc_ret_high_usec;
             : 		/* From retention mode voltage to low current mode voltage */
             : 		unsigned int vcc_ret_low_usec;
             : 		/* From off(0V) to high current mode voltage */
             : 		unsigned int vcc_off_high_usec;
> It seems like "us" is more often used for µs along the tree than usec. […]

Done