Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45139 )
Change subject: pci_ids: Add ADL IPU PCI IDs ......................................................................
pci_ids: Add ADL IPU PCI IDs
Add PCI IDs for Intel's Image Processing Unit (IPU) for ADL
Change-Id: I327828d676422fc6162fadffd9b39529ecb89ace Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/device/pci_ids.h M src/soc/intel/common/block/ipu/ipu.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/45139/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 5aaf7b3..dd0df54 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3966,6 +3966,7 @@
#define PCI_DEVICE_ID_INTEL_TGL_IPU 0x9a19 #define PCI_DEVICE_ID_INTEL_JSL_IPU 0x4e19 +#define PCI_DEVICE_ID_INTEL_ADL_IPU 0x465d
/* Intel Dynamic Tuning Technology Device */ #define PCI_DEVICE_ID_INTEL_CML_DTT 0x1903 diff --git a/src/soc/intel/common/block/ipu/ipu.c b/src/soc/intel/common/block/ipu/ipu.c index f7b01aa..844d88e 100644 --- a/src/soc/intel/common/block/ipu/ipu.c +++ b/src/soc/intel/common/block/ipu/ipu.c @@ -14,6 +14,8 @@ static const uint16_t pci_device_ids[] = { PCI_DEVICE_ID_INTEL_TGL_IPU, PCI_DEVICE_ID_INTEL_JSL_IPU, + PCI_DEVICE_ID_INTEL_ADL_IPU, + 0 };
static const struct pci_driver intel_ipu __pci_driver = {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45139 )
Change subject: pci_ids: Add ADL IPU PCI IDs ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG@7 PS1, Line 7: ADL nit: I would use `Alder Lake` here
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG@9 PS1, Line 9: Add PCI IDs for Intel's Image Processing Unit (IPU) for ADL nit: missing period at the end
https://review.coreboot.org/c/coreboot/+/45139/1/src/soc/intel/common/block/... File src/soc/intel/common/block/ipu/ipu.c:
https://review.coreboot.org/c/coreboot/+/45139/1/src/soc/intel/common/block/... PS1, Line 17: PCI_DEVICE_ID_INTEL_ADL_IPU, Please mention this change in the commit message
Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45139
to look at the new patch set (#2).
Change subject: pci_ids: Add Alder Lake IPU PCI IDs ......................................................................
pci_ids: Add Alder Lake IPU PCI IDs
Add PCI IDs for Intel's Image Processing Unit (IPU) for ADL.
Also add NULL terminator at end of pci_device_ids.
Change-Id: I327828d676422fc6162fadffd9b39529ecb89ace Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/device/pci_ids.h M src/soc/intel/common/block/ipu/ipu.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/45139/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45139 )
Change subject: pci_ids: Add Alder Lake IPU PCI IDs ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG@7 PS1, Line 7: ADL
nit: I would use `Alder Lake` here
Ack
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG@9 PS1, Line 9: Add PCI IDs for Intel's Image Processing Unit (IPU) for ADL
nit: missing period at the end
Ack
https://review.coreboot.org/c/coreboot/+/45139/1/src/soc/intel/common/block/... File src/soc/intel/common/block/ipu/ipu.c:
https://review.coreboot.org/c/coreboot/+/45139/1/src/soc/intel/common/block/... PS1, Line 17: PCI_DEVICE_ID_INTEL_ADL_IPU,
Please mention this change in the commit message
Ack
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45139 )
Change subject: pci_ids: Add Alder Lake IPU PCI IDs ......................................................................
pci_ids: Add Alder Lake IPU PCI IDs
Add PCI IDs for Intel's Image Processing Unit (IPU) for ADL.
Also add NULL terminator at end of pci_device_ids.
Change-Id: I327828d676422fc6162fadffd9b39529ecb89ace Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45139 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/include/device/pci_ids.h M src/soc/intel/common/block/ipu/ipu.c 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 9ef6f0a..a7f0fec 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3967,6 +3967,7 @@
#define PCI_DEVICE_ID_INTEL_TGL_IPU 0x9a19 #define PCI_DEVICE_ID_INTEL_JSL_IPU 0x4e19 +#define PCI_DEVICE_ID_INTEL_ADL_IPU 0x465d
/* Intel Dynamic Tuning Technology Device */ #define PCI_DEVICE_ID_INTEL_CML_DTT 0x1903 diff --git a/src/soc/intel/common/block/ipu/ipu.c b/src/soc/intel/common/block/ipu/ipu.c index f7b01aa..844d88e 100644 --- a/src/soc/intel/common/block/ipu/ipu.c +++ b/src/soc/intel/common/block/ipu/ipu.c @@ -14,6 +14,8 @@ static const uint16_t pci_device_ids[] = { PCI_DEVICE_ID_INTEL_TGL_IPU, PCI_DEVICE_ID_INTEL_JSL_IPU, + PCI_DEVICE_ID_INTEL_ADL_IPU, + 0 };
static const struct pci_driver intel_ipu __pci_driver = {
-
Angel Pons (Code Review) -
Subrata Banik (Code Review)