Change in coreboot[master]: soc/amd/picasso: move MAX_CPUS setting from mainbaord to SoC Kconfig
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainbaord to SoC Kconfig ......................................................................
soc/amd/picasso: move MAX_CPUS setting from mainbaord to SoC Kconfig
Since the mainboard Kconfig is sourced before the SoC one, it's still possible to override that setting on per-mainboard basis. The maximum CPU for Picasso is 8, since the chips have only up to 4 cores with up to two threads each.
Change-Id: I53449b8fa73c5d13e6ea77bee6eed8896b7d3ec3 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig M src/mainboard/google/zork/Kconfig M src/soc/amd/picasso/Kconfig 3 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/47205/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 8e2bd8b..f4032d4 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -52,10 +52,6 @@ string default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
-config MAX_CPUS - int - default 8 - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index c4f6bf7..eb9092a 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -96,10 +96,6 @@ string default "Google_Zork"
-config MAX_CPUS - int - default 8 - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 605b0ea..bae2d28 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -193,6 +193,10 @@ hex default 0x4000000
+config MAX_CPUS + int + default 8 + config VGA_BIOS_ID string default "1002,15d8,c1"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainbaord to SoC Kconfig ......................................................................
Patch Set 1: Code-Review+2
I'd suggest against overriding the MAX_CPUS value from mainboards. I don't believe it provides any meaningful benefit and can cause problems in the long run.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainbaord to SoC Kconfig ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
I'd suggest against overriding the MAX_CPUS value from mainboards. I don't believe it provides any meaningful benefit and can cause problems in the long run.
I agree; just wanted to point out that a per mainboard setting would still be possible
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainbaord to SoC Kconfig ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47205/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47205/1//COMMIT_MSG@7 PS1, Line 7: mainbaord typo: mainboard
Hello build bot (Jenkins), Jason Glenesk, Furquan Shaikh, Marshall Dawson, Angel Pons, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47205
to look at the new patch set (#2).
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainboard to SoC Kconfig ......................................................................
soc/amd/picasso: move MAX_CPUS setting from mainboard to SoC Kconfig
Since the mainboard Kconfig is sourced before the SoC one, it would still be possible to override this setting at mainboard level, even though that shouldn't be needed. The maximum CPU count for Picasso is 8, since the chips have only up to 4 cores with up to two threads each.
Change-Id: I53449b8fa73c5d13e6ea77bee6eed8896b7d3ec3 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig M src/mainboard/google/zork/Kconfig M src/soc/amd/picasso/Kconfig 3 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/47205/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainboard to SoC Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47205/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47205/1//COMMIT_MSG@7 PS1, Line 7: mainbaord
typo: mainboard
fixed and since I was editing the commit message anyway, I also added that the possible override at mainboard level shouldn't be needed
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainboard to SoC Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47205/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47205/1//COMMIT_MSG@7 PS1, Line 7: mainbaord
fixed and since I was editing the commit message anyway, I also added that the possible override at […]
thanks!
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainboard to SoC Kconfig ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainboard to SoC Kconfig ......................................................................
soc/amd/picasso: move MAX_CPUS setting from mainboard to SoC Kconfig
Since the mainboard Kconfig is sourced before the SoC one, it would still be possible to override this setting at mainboard level, even though that shouldn't be needed. The maximum CPU count for Picasso is 8, since the chips have only up to 4 cores with up to two threads each.
Change-Id: I53449b8fa73c5d13e6ea77bee6eed8896b7d3ec3 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47205 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/Kconfig M src/mainboard/google/zork/Kconfig M src/soc/amd/picasso/Kconfig 3 files changed, 4 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 8e2bd8b..f4032d4 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -52,10 +52,6 @@ string default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
-config MAX_CPUS - int - default 8 - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index c4f6bf7..eb9092a 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -96,10 +96,6 @@ string default "Google_Zork"
-config MAX_CPUS - int - default 8 - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 605b0ea..bae2d28 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -193,6 +193,10 @@ hex default 0x4000000
+config MAX_CPUS + int + default 8 + config VGA_BIOS_ID string default "1002,15d8,c1"
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Marshall Dawson (Code Review)