[XL] Change in coreboot[master]: x86: Change MMIO addr in readN(addr)/writeN(addr, val) to pointer - coreboot-gerrit

26 Jun 2024


      Attention is currently required from: Kevin Paul Herbert.
Elyes Haouas has posted comments on this change by Kevin Paul Herbert. ( https://review.coreboot.org/c/coreboot/+/7784?usp=email )
Change subject: x86: Change MMIO addr in readN(addr)/writeN(addr, val) to pointer
......................................................................
Patch Set 10:
(1 comment)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/7784/comment/092b5fc0_6cb7e84d?usp=... :
PS10, Line 62:  codec_detect(u8 *base)
Please why the "base" changed from `u32` to `u8`?
shouldn't be `uintptr_t`
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/7784?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic26dd8a72d82828b69be3c04944710681b7bd330
Gerrit-Change-Number: 7784
Gerrit-PatchSet: 10
Gerrit-Owner: Kevin Paul Herbert kph@meraki.net
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Alexandru Gagniuc alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Kevin Paul Herbert kph@meraki.net
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Ron Minnich rminnich@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@chromium.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Kevin Paul Herbert kph@meraki.net
Gerrit-Comment-Date: Wed, 26 Jun 2024 08:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No