Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Dtrain Hsu, Ian Feng, Jamie Chen, Kenny Pan, Paul Menzel, Shou-Chieh Hsu, Sumeet R Pawnikar, Tarun Tuli.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76636?usp=email )
Change subject: mb/google/nissa/var/craaskov: Configure GPIOs according to schematics
......................................................................
Patch Set 12:
(2 comments)
File src/mainboard/google/brya/variants/craaskov/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76636/comment/966b563a_1481dae1 :
PS11, Line 4: romstage-y += gpio.c
no override when romstage.
No override, so remove it.
File src/mainboard/google/brya/variants/craaskov/gpio.c:
https://review.coreboot.org/c/coreboot/+/76636/comment/37588099_9a00af72 :
PS11, Line 68: static const struct pad_config romstage_gpio_table[] = {
you can remove it if empty.
romstage_gpio_table is empty, so remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76636?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17fc9333a0ef592ea36b196b3fd417be47fb82bb
Gerrit-Change-Number: 76636
Gerrit-PatchSet: 12
Gerrit-Owner: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kenny Pan
kennypan@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Kenny Pan
kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Tue, 01 Aug 2023 08:36:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment