[M] Change in coreboot[main]: Choose Correct FW splash screen at runtime

[Julius Werner (Code Review)]

Attention is currently required from: Andrey Petrov, Ronak Kanabar, Shelley Chen, Subrata Banik.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: Choose Correct FW splash screen at runtime
......................................................................

Patch Set 8: Code-Review+2

(4 comments)

File src/include/bootsplash.h:

https://review.coreboot.org/c/coreboot/+/79775/comment/2879d3a4_e6a59a70 :
PS8, Line 24: get_bmp_file
nit: Since this is now an exported function I think it should start with `bmp_` for cleaner namespacing (e.g. `bmp_logo_filename()` or something like that).

File src/lib/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/6ce1e835_d64f11e2 :
PS6, Line 153: HAVE_CUSTOM_BMP_LOGO
> Acknowledged

It probably makes sense to inject these options from the ebuild based on a USE flag.

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/2546d0f8_dd55aa59 :
PS8, Line 88: to
nit: typo?

https://review.coreboot.org/c/coreboot/+/79775/comment/278fc528_b85dfe9d :
PS8, Line 89: an
nit: typo?