Attention is currently required from: Andrey Petrov, Ronak Kanabar, Shelley Chen, Subrata Banik.

Patch set 8:Code-Review +2

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

View Change

4 comments:

• File src/include/bootsplash.h:

  • Patch Set #8, Line 24: get_bmp_file

    nit: Since this is now an exported function I think it should start with `bmp_` for cleaner namespacing (e.g. `bmp_logo_filename()` or something like that).

• File src/lib/Kconfig:

  • Patch Set #6, Line 153: HAVE_CUSTOM_BMP_LOGO

    Acknowledged

    It probably makes sense to inject these options from the ebuild based on a USE flag.

• File src/vendorcode/google/chromeos/Kconfig:

  • Patch Set #8, Line 88: to

    nit: typo?

  • Patch Set #8, Line 89: an

    nit: typo?

To view, visit change 79775. To unsubscribe, or for help writing mail filters, visit settings.