Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31548 )
Change subject: security: Add memory subfolder ......................................................................
Patch Set 10:
(4 comments)
Let's do some more bikeshedding :D
https://review.coreboot.org/#/c/31548/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31548/10//COMMIT_MSG@7 PS10, Line 7: subfolder I guess the technical term is `subdirectory`. After all, it's not really a folder.
https://review.coreboot.org/#/c/31548/10//COMMIT_MSG@9 PS10, Line 9: framework Is this a framework or a mere library?
https://review.coreboot.org/#/c/31548/10/Documentation/security/memory_clear... File Documentation/security/memory_clearing.md:
https://review.coreboot.org/#/c/31548/10/Documentation/security/memory_clear... PS10, Line 14: every : The device grammar
https://review.coreboot.org/#/c/31548/10/src/security/memory/memory.c File src/security/memory/memory.c:
https://review.coreboot.org/#/c/31548/10/src/security/memory/memory.c@17 PS10, Line 17: #include <stdint.h> Needless include
-
Alex Thiessen (Code Review)