Attention is currently required from: Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63888 )
Change subject: soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63888/comment/63edd610_0e553fbe PS2, Line 38: udelay(TSN_GMII_DELAY_US); Do you need this udelay() here at all? Are there restrictions in how often you can read the busy bit? If not we could get rind of it completely, stopwatch will handle the rest.
https://review.coreboot.org/c/coreboot/+/63888/comment/cb4b20ba_ba71dc9b PS2, Line 44: Timeout at %ld Maybe: "Timeout after %ld msec"