Change in coreboot[master]: soc/intel: Constify struct device * parameter to intel_igd_get_contro...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40709 )

Change subject: soc/intel: Constify struct device * parameter to intel_igd_get_controller_info
......................................................................

soc/intel: Constify struct device * parameter to intel_igd_get_controller_info

intel_igd_get_controller_info() does not need to modify the device
structure. Hence, this change makes the struct device * parameter to
intel_igd_get_controller_info() as const.

Change-Id: Ic044a80e3e2c45af6824a23f3cd0b08b94c0f279
Signed-off-by: Furquan Shaikh 
---
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/common/block/include/intelblocks/graphics.h
M src/soc/intel/skylake/graphics.c
3 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/40709/1

diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c
index 55c181b..5392958 100644
--- a/src/soc/intel/common/block/graphics/graphics.c
+++ b/src/soc/intel/common/block/graphics/graphics.c
@@ -34,12 +34,12 @@
 }

__weak const struct i915_gpu_controller_info *
-intel_igd_get_controller_info(struct device *device)
+intel_igd_get_controller_info(const struct device *device)
 {
    return NULL;
 }

-static void gma_generate_ssdt(struct device *device)
+static void gma_generate_ssdt(const struct device *device)
 {
    const struct i915_gpu_controller_info *gfx = intel_igd_get_controller_info(device);

diff --git a/src/soc/intel/common/block/include/intelblocks/graphics.h b/src/soc/intel/common/block/include/intelblocks/graphics.h
index 4187ca1..378fdd0 100644
--- a/src/soc/intel/common/block/include/intelblocks/graphics.h
+++ b/src/soc/intel/common/block/include/intelblocks/graphics.h
@@ -35,7 +35,7 @@

/* i915 controller info for ACPI backlight controls */
 const struct i915_gpu_controller_info *
-intel_igd_get_controller_info(struct device *device);
+intel_igd_get_controller_info(const struct device *device);

/* Graphics MMIO register read/write APIs */
 uint32_t graphics_gtt_read(unsigned long reg);
diff --git a/src/soc/intel/skylake/graphics.c b/src/soc/intel/skylake/graphics.c
index 5be398c..e1f8fbd 100644
--- a/src/soc/intel/skylake/graphics.c
+++ b/src/soc/intel/skylake/graphics.c
@@ -177,7 +177,7 @@
 }

const struct i915_gpu_controller_info *
-intel_igd_get_controller_info(struct device *device)
+intel_igd_get_controller_info(const struct device *device)
 {
    struct soc_intel_skylake_config *chip = device->chip_info;
    return &chip->gfx;

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Aaron Durbin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40709

to look at the new patch set (#4).

Change subject: soc/intel: Constify struct device * parameter to intel_igd_get_controller_info
......................................................................

soc/intel: Constify struct device * parameter to intel_igd_get_controller_info

intel_igd_get_controller_info() does not need to modify the device
structure. Hence, this change makes the struct device * parameter to
intel_igd_get_controller_info() as const.

Change-Id: Ic044a80e3e2c45af6824a23f3cd0b08b94c0f279
Signed-off-by: Furquan Shaikh 
---
M src/arch/x86/acpi_device.c
M src/arch/x86/include/arch/acpi.h
M src/arch/x86/include/arch/acpi_device.h
M src/cpu/intel/haswell/acpi.c
M src/cpu/intel/model_2065x/acpi.c
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/speedstep/acpi.c
M src/device/pci_rom.c
M src/drivers/crb/tis.c
M src/drivers/generic/adau7002/adau7002.c
M src/drivers/generic/generic/generic.c
M src/drivers/generic/gpio_keys/gpio_keys.c
M src/drivers/generic/gpio_regulator/gpio_regulator.c
M src/drivers/generic/max98357a/max98357a.c
M src/drivers/gfx/generic/generic.c
M src/drivers/i2c/da7219/da7219.c
M src/drivers/i2c/designware/dw_i2c.c
M src/drivers/i2c/designware/dw_i2c.h
M src/drivers/i2c/generic/chip.h
M src/drivers/i2c/generic/generic.c
M src/drivers/i2c/hid/hid.c
M src/drivers/i2c/max98373/max98373.c
M src/drivers/i2c/max98927/max98927.c
M src/drivers/i2c/nau8825/nau8825.c
M src/drivers/i2c/rt1011/rt1011.c
M src/drivers/i2c/rt5663/rt5663.c
M src/drivers/i2c/sx9310/sx9310.c
M src/drivers/i2c/tpm/chip.c
M src/drivers/intel/ish/ish.c
M src/drivers/intel/mipi_camera/camera.c
M src/drivers/intel/wifi/wifi.c
M src/drivers/ipmi/ipmi_kcs_ops.c
M src/drivers/net/r8168.c
M src/drivers/pc80/tpm/tis.c
M src/drivers/spi/acpi/acpi.c
M src/drivers/usb/acpi/usb_acpi.c
M src/drivers/wifi/generic.c
M src/drivers/wifi/generic_wifi.h
M src/ec/google/chromeec/ec.h
M src/ec/google/chromeec/ec_acpi.c
M src/ec/google/wilco/chip.c
M src/ec/lenovo/h8/h8.h
M src/ec/lenovo/h8/ssdt.c
M src/include/device/device.h
M src/include/device/pci_rom.h
M src/mainboard/lenovo/x200/mainboard.c
M src/mainboard/lenovo/x201/mainboard.c
M src/mainboard/lenovo/x60/mainboard.c
M src/northbridge/amd/agesa/family14/northbridge.c
M src/northbridge/amd/agesa/family15tn/northbridge.c
M src/northbridge/amd/agesa/family16kb/northbridge.c
M src/northbridge/amd/pi/00630F01/northbridge.c
M src/northbridge/amd/pi/00660F01/northbridge.c
M src/northbridge/amd/pi/00730F01/northbridge.c
M src/northbridge/intel/gm45/gma.c
M src/northbridge/intel/haswell/gma.c
M src/northbridge/intel/i945/gma.c
M src/northbridge/intel/ironlake/gma.c
M src/northbridge/intel/sandybridge/gma.c
M src/northbridge/intel/x4x/gma.c
M src/soc/amd/picasso/acpi.c
M src/soc/amd/picasso/northbridge.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/amd/stoneyridge/northbridge.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/baytrail/gfx.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/braswell/gfx.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/broadwell/igd.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/common/block/include/intelblocks/graphics.h
M src/soc/intel/common/block/scs/sd.c
M src/soc/intel/skylake/acpi.c
M src/soc/intel/skylake/graphics.c
M src/soc/intel/xeon_sp/skx/acpi.c
M src/southbridge/intel/bd82x6x/lpc.c
M src/southbridge/intel/bd82x6x/sata.c
M src/southbridge/intel/common/acpi_pirq_gen.c
M src/southbridge/intel/common/acpi_pirq_gen.h
M src/southbridge/intel/i82371eb/acpi_tables.c
M src/southbridge/intel/i82371eb/isa.c
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801ix/lpc.c
M src/southbridge/intel/i82801jx/lpc.c
M src/southbridge/intel/ibexpeak/lpc.c
M src/southbridge/intel/ibexpeak/sata.c
M src/southbridge/intel/lynxpoint/lpc.c
M src/superio/common/generic.c
M src/superio/common/ssdt.c
M src/superio/common/ssdt.h
M src/superio/nuvoton/npcd378/superio.c
93 files changed, 105 insertions(+), 105 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/40709/4

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Damien Zammit, Christian Walter, Alexander Couzens, Aaron Durbin, Patrick Rudolph, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40709

to look at the new patch set (#6).

Change subject: soc/intel: Constify struct device * parameter to intel_igd_get_controller_info
......................................................................

soc/intel: Constify struct device * parameter to intel_igd_get_controller_info

intel_igd_get_controller_info() does not need to modify the device
structure. Hence, this change makes the struct device * parameter to
intel_igd_get_controller_info() as const.

Change-Id: Ic044a80e3e2c45af6824a23f3cd0b08b94c0f279
Signed-off-by: Furquan Shaikh 
---
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/common/block/include/intelblocks/graphics.h
M src/soc/intel/skylake/graphics.c
3 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/40709/6

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Damien Zammit, Christian Walter, Alexander Couzens, Aaron Durbin, Patrick Rudolph, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40709

to look at the new patch set (#8).

Change subject: soc/intel: Constify struct device * parameter to intel_igd_get_controller_info
......................................................................

soc/intel: Constify struct device * parameter to intel_igd_get_controller_info

intel_igd_get_controller_info() does not need to modify the device
structure. Hence, this change makes the struct device * parameter to
intel_igd_get_controller_info() as const.

Change-Id: Ic044a80e3e2c45af6824a23f3cd0b08b94c0f279
Signed-off-by: Furquan Shaikh 
---
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/common/block/include/intelblocks/graphics.h
M src/soc/intel/skylake/graphics.c
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/40709/8

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40709 )

Change subject: soc/intel: Constify struct device * parameter to intel_igd_get_controller_info
......................................................................

Patch Set 8: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40709 )

Change subject: soc/intel: Constify struct device * parameter to intel_igd_get_controller_info
......................................................................

soc/intel: Constify struct device * parameter to intel_igd_get_controller_info

intel_igd_get_controller_info() does not need to modify the device
structure. Hence, this change makes the struct device * parameter to
intel_igd_get_controller_info() as const.

Change-Id: Ic044a80e3e2c45af6824a23f3cd0b08b94c0f279
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40709
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
---
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/common/block/include/intelblocks/graphics.h
M src/soc/intel/skylake/graphics.c
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c
index 55c181b..a6d45c6 100644
--- a/src/soc/intel/common/block/graphics/graphics.c
+++ b/src/soc/intel/common/block/graphics/graphics.c
@@ -34,7 +34,7 @@
 }

__weak const struct i915_gpu_controller_info *
-intel_igd_get_controller_info(struct device *device)
+intel_igd_get_controller_info(const struct device *device)
 {
    return NULL;
 }
diff --git a/src/soc/intel/common/block/include/intelblocks/graphics.h b/src/soc/intel/common/block/include/intelblocks/graphics.h
index 4187ca1..378fdd0 100644
--- a/src/soc/intel/common/block/include/intelblocks/graphics.h
+++ b/src/soc/intel/common/block/include/intelblocks/graphics.h
@@ -35,7 +35,7 @@

/* i915 controller info for ACPI backlight controls */
 const struct i915_gpu_controller_info *
-intel_igd_get_controller_info(struct device *device);
+intel_igd_get_controller_info(const struct device *device);

/* Graphics MMIO register read/write APIs */
 uint32_t graphics_gtt_read(unsigned long reg);
diff --git a/src/soc/intel/skylake/graphics.c b/src/soc/intel/skylake/graphics.c
index 5be398c..e1f8fbd 100644
--- a/src/soc/intel/skylake/graphics.c
+++ b/src/soc/intel/skylake/graphics.c
@@ -177,7 +177,7 @@
 }

const struct i915_gpu_controller_info *
-intel_igd_get_controller_info(struct device *device)
+intel_igd_get_controller_info(const struct device *device)
 {
    struct soc_intel_skylake_config *chip = device->chip_info;
    return &chip->gfx;