Change in coreboot[master]: soc/intel/skylake: acpi: drop HWP's dependency on EIST

[Michael Niewöhner (Code Review)]

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44137 )

Change subject: soc/intel/skylake: acpi: drop HWP's dependency on EIST
......................................................................

soc/intel/skylake: acpi: drop HWP's dependency on EIST

Enhanced Intel SpeedStep Technology (EIST) and Intel Speed Shift
Technology (ISST) - also know as HWP - are two independent mechanisms
for controlling voltage and frequency based on performance hints.

When HWP is enabled, it overrides the software-based EIST. It does not
depend on EIST, though, but can be enabled on its own.

Break up that currently existing dependency in ACPI generation code.

It was tested that HWP can be enabled and gets used by the Linux pstate
cpufreq driver. With HWP disabled, the frequency does not decrease, even
not in powersave mode. After enabling HWP the frequency changed in
relation to the current workload. (Test device: Acer ES1-572)

Change-Id: I93d888ddce7b54e91b54e5b4fdd4d9cf16630eda
Signed-off-by: Michael Niewöhner 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44137
Reviewed-by: Arthur Heymans 
Reviewed-by: Subrata Banik 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/skylake/acpi.c
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, but someone else must approve
  Subrata Banik: Looks good to me, approved

diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index 0ec6e47..eb5b5b0 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -379,7 +379,7 @@
    printk(BIOS_DEBUG, "Found %d CPU(s) with %d core(s) each.\n",
           numcpus, cores_per_package);

-	if (config->eist_enable && config->speed_shift_enable) {
+	if (config->speed_shift_enable) {
    	struct cppc_config cppc_config;
    	cpu_init_cppc_config(&cppc_config, 2 /* version 2 */);
    	acpigen_write_CPPC_package(&cppc_config);
@@ -403,9 +403,11 @@
    			/* Generate P-state tables */
    			generate_p_state_entries(core_id,
    					cores_per_package);
-				if (config->speed_shift_enable)
-					acpigen_write_CPPC_method();
    		}
+
+			if (config->speed_shift_enable)
+				acpigen_write_CPPC_method();
+
    		acpigen_pop_len();
    	}
    }