Attention is currently required from: David Wu, Dinesh Gehlot, Eran Mitrani, Jack Lai, Jakub Czapiga, Kapil Porwal, Mac Chiang, Tarun, Tyler Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79765?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/karis: Enhance CNVi and PCIe switching
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79765/comment/89d8836b_d349d396 :
PS2, Line 9: Set PCIe related GPIOs to NC if fw_config use "WIFI_CNVI".
: Set CNVi related GPIOs to NC if fw_config use "WIFI_PCIE".
: Remove "ALC5650_NO_AMP_I2S" case in fw_config_gpio_padbased_override().
: bt_i2s_enable_pads should not relevant to audio codec/amp, and it is
: already enabled in "WIFI_CNVI" case.
If you enumerate items, please format this as a list.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79765?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1a32f1a38ae33cf992b80a3408aa8e2fa3ddab0
Gerrit-Change-Number: 79765
Gerrit-PatchSet: 2
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jack Lai
jack.lai@intel.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jack Lai
jack.lai@intel.corp-partner.google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Mac Chiang
mac.chiang@intel.corp-partner.google.com
Gerrit-Comment-Date: Sat, 30 Dec 2023 05:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment