Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50454 )
Change subject: soc/amd/cezanne/fch: add HAVE_SMI_HANDLER case to fch_init_acpi_ports
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/cezanne/fch.c:
https://review.coreboot.org/c/coreboot/+/50454/comment/27b69513_3f566926
PS3, Line 28:
: /*
: * SMI on SlpTyp requires sending SMI before completion
: * response of the I/O write. The BKDG also specifies
: * clearing ForceStpClkRetry for SMI trapping.
: */
I don't understand how this comment relates to the following code.
If we need to clear ForceStpClkRetry, why is it getting set?
Where is the SMI that needs to be sent before the completion response?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50454
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7bab29ae8d0e28c392210f8dcbaa4441ca61114
Gerrit-Change-Number: 50454
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 Feb 2021 16:17:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment