Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email )
Change subject: mb/google/brya: Add new baseboard trulo ......................................................................
Patch Set 10:
(4 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81626/comment/686af233_b59a3ef1 : PS10, Line 656: chromeos-nissa-16MiB-debugfsp.fmd chromeos-16MiB-debugfsp.fmd
https://review.coreboot.org/c/coreboot/+/81626/comment/7b3f2ff6_04f151db : PS10, Line 657: chromeos-nissa-16MiB chromeos-16MiB.fmd
https://review.coreboot.org/c/coreboot/+/81626/comment/0612e8bb_5c7851b4 : PS10, Line 658: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-nissa-32MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_NISSA && BOARD_ROMSIZE_KB_32768 we can drop this
https://review.coreboot.org/c/coreboot/+/81626/comment/4139d1a4_8f0e5e73 : PS10, Line 659: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-16MiB-debugfsp.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_16384 && BUILDING_WITH_DEBUG_FSP : default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-16MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_16384 : default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-32MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_32768 do we really need yet another layout ? can't we use the same nissa layout. we can always drop `nissa` keyword from the file name
-
Subrata Banik (Code Review)