Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54001 )
Change subject: util/genbuild_h: Update IASL location finding code
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54001/comment/7409843f_1357bfe7
PS2, Line 23: but on an initial build, this check couldn't find iasl.
Is this hard to fix? As I understood CB:53997, we would only
call genbuild_h on a regular build now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2f8dca0be8bfb54d3c672fab6cf6f005bb394c3
Gerrit-Change-Number: 54001
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 12 May 2021 21:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment