Change in coreboot[master]: mb/google/poppy/variants/rammus: add sku info into smbios table
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/28426 )
Change subject: mb/google/poppy/variants/rammus: add sku info into smbios table ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/rammus/include/variant/sku.h:
https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants/... PS1, Line 19:
Are you expecting this will be used outside mainboard.c? Else it can live in the . […]
Ok, let's put it to mainboard.c file.
https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/rammus/mainboard.c:
https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants/... PS1, Line 20:
local ?
Done
-
Zhuohao Lee (Code Review)