Change in coreboot[master]: soc/intel/broadwell: Move MAX_CPUS from mb to SoC

[Felix Singer (Code Review)]

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

soc/intel/broadwell: Move MAX_CPUS from mb to SoC

Configure MAX_CPUS in SoC Kconfig with 8 as default value and remove it
from every mainboard where 8 is used.

Change-Id: I311b95ea75a7c6b76b32c7197a0cec86db644234
Signed-off-by: Felix Singer 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/purism/librem_bdw/Kconfig
3 files changed, 0 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/49122/1

diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig
index 8e49255..5301e32 100644
--- a/src/mainboard/google/auron/Kconfig
+++ b/src/mainboard/google/auron/Kconfig
@@ -58,10 +58,6 @@
    default "samus" if BOARD_GOOGLE_SAMUS
    default ""

-config MAX_CPUS
-	int
-	default 8
-
 config VGA_BIOS_FILE
    string
    default "pci8086,0406.rom"
diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig
index 5955565..b04cc46 100644
--- a/src/mainboard/google/jecht/Kconfig
+++ b/src/mainboard/google/jecht/Kconfig
@@ -39,10 +39,6 @@
    default "Rikku" if BOARD_GOOGLE_RIKKU
    default "Tidus" if BOARD_GOOGLE_TIDUS

-config MAX_CPUS
-	int
-	default 8
-
 config VGA_BIOS_FILE
    string
    default "pci8086,0406.rom"
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig
index 275594b..ad764b7 100644
--- a/src/mainboard/purism/librem_bdw/Kconfig
+++ b/src/mainboard/purism/librem_bdw/Kconfig
@@ -52,10 +52,6 @@
    default "1.0" if BOARD_PURISM_LIBREM13_V1
    default "2.0" if BOARD_PURISM_LIBREM15_V2

-config MAX_CPUS
-	int
-	default 8
-
 config PRE_GRAPHICS_DELAY
    int
    default 50

[Felix Singer (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49122

to look at the new patch set (#2).

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

soc/intel/broadwell: Move MAX_CPUS from mb to SoC

Configure MAX_CPUS in SoC Kconfig with 8 as default value and remove it
from every mainboard where 8 is used.

Change-Id: I311b95ea75a7c6b76b32c7197a0cec86db644234
Signed-off-by: Felix Singer 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/purism/librem_bdw/Kconfig
M src/soc/intel/broadwell/Kconfig
4 files changed, 4 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/49122/2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

Patch Set 2: Code-Review+2

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

Patch Set 2:

Angel, could you rebase CB:46952 on this one? So you can just remove MAX_CPUS in your patch.

[Felix Singer (Code Review)]

Hello build bot (Jenkins), Matt DeVillier, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49122

to look at the new patch set (#3).

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

soc/intel/broadwell: Move MAX_CPUS from mb to SoC

Configure MAX_CPUS in SoC Kconfig with 8 as default value and remove it
from every mainboard where 8 is used.

Change-Id: I311b95ea75a7c6b76b32c7197a0cec86db644234
Signed-off-by: Felix Singer 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/intel/wtm2/Kconfig
M src/mainboard/purism/librem_bdw/Kconfig
M src/soc/intel/broadwell/Kconfig
5 files changed, 4 insertions(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/49122/3

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/49122/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/49122/3//COMMIT_MSG@9 
PS3, Line 9: Configure MAX_CPUS in SoC Kconfig with 8 as default value and remove it
           : from every mainboard where 8 is used.
I would mention that *all* Broadwell boards use 8, which is the reason behind this change:

All Broadwell boards use 8 for MAX_CPUS, so this option can be factored out into SoC Kconfig.

[Felix Singer (Code Review)]

Hello build bot (Jenkins), Matt DeVillier, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49122

to look at the new patch set (#4).

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

soc/intel/broadwell: Move MAX_CPUS from mb to SoC

All Broadwell boards use 8 for MAX_CPUS, so this option can be factored
out into SoC Kconfig.

Change-Id: I311b95ea75a7c6b76b32c7197a0cec86db644234
Signed-off-by: Felix Singer 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/intel/wtm2/Kconfig
M src/mainboard/purism/librem_bdw/Kconfig
M src/soc/intel/broadwell/Kconfig
5 files changed, 4 insertions(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/49122/4

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/49122/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/49122/3//COMMIT_MSG@9 
PS3, Line 9: Configure MAX_CPUS in SoC Kconfig with 8 as default value and remove it
           : from every mainboard where 8 is used.
> I would mention that *all* Broadwell boards use 8, which is the reason behind this change: […]

Oh, right. Thanks for that clarification :)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

Patch Set 4: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

Patch Set 4: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49122 )

Change subject: soc/intel/broadwell: Move MAX_CPUS from mb to SoC
......................................................................

soc/intel/broadwell: Move MAX_CPUS from mb to SoC

All Broadwell boards use 8 for MAX_CPUS, so this option can be factored
out into SoC Kconfig.

Change-Id: I311b95ea75a7c6b76b32c7197a0cec86db644234
Signed-off-by: Felix Singer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49122
Reviewed-by: Angel Pons 
Reviewed-by: Michael Niewöhner 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/intel/wtm2/Kconfig
M src/mainboard/purism/librem_bdw/Kconfig
M src/soc/intel/broadwell/Kconfig
5 files changed, 4 insertions(+), 17 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig
index 8e49255..5301e32 100644
--- a/src/mainboard/google/auron/Kconfig
+++ b/src/mainboard/google/auron/Kconfig
@@ -58,10 +58,6 @@
    default "samus" if BOARD_GOOGLE_SAMUS
    default ""

-config MAX_CPUS
-	int
-	default 8
-
 config VGA_BIOS_FILE
    string
    default "pci8086,0406.rom"
diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig
index 5955565..b04cc46 100644
--- a/src/mainboard/google/jecht/Kconfig
+++ b/src/mainboard/google/jecht/Kconfig
@@ -39,10 +39,6 @@
    default "Rikku" if BOARD_GOOGLE_RIKKU
    default "Tidus" if BOARD_GOOGLE_TIDUS

-config MAX_CPUS
-	int
-	default 8
-
 config VGA_BIOS_FILE
    string
    default "pci8086,0406.rom"
diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig
index 6ca9949..7ac5f1c 100644
--- a/src/mainboard/intel/wtm2/Kconfig
+++ b/src/mainboard/intel/wtm2/Kconfig
@@ -25,11 +25,6 @@
    string
    default "WHITETIP MOUNTAIN 2"

-
-config MAX_CPUS
-	int
-	default 8
-
 config VGA_BIOS_FILE
    string
    default "pci8086,0166.rom"
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig
index 275594b..ad764b7 100644
--- a/src/mainboard/purism/librem_bdw/Kconfig
+++ b/src/mainboard/purism/librem_bdw/Kconfig
@@ -52,10 +52,6 @@
    default "1.0" if BOARD_PURISM_LIBREM13_V1
    default "2.0" if BOARD_PURISM_LIBREM15_V2

-config MAX_CPUS
-	int
-	default 8
-
 config PRE_GRAPHICS_DELAY
    int
    default 50
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig
index 6e57f0a..e70966c 100644
--- a/src/soc/intel/broadwell/Kconfig
+++ b/src/soc/intel/broadwell/Kconfig
@@ -39,6 +39,10 @@
    select HAVE_POWER_STATE_AFTER_FAILURE
    select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE

+config MAX_CPUS
+	int
+	default 8
+
 config PCIEXP_ASPM
    bool
    default y