Attention is currently required from: Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69089 )
Change subject: soc/mediatek/mt8188: Disable CPU input gating ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69089/comment/fd53ae27_406561cd PS1, Line 7: Disable CPU input gating Fix AP hanging issue due to CPU input gating
https://review.coreboot.org/c/coreboot/+/69089/comment/39b792b7_38f911d3 PS1, Line 9: This patch fixes AP hanging issue caused by CPU input gating. The : feature should be disabled by default, so we disable it. If it's by default disabled then we don't need to anything, isn't it? 😊
I think this description should probably be rephrased by 3 topics: - What is CPU input gating - Why keep it enabled would cause AP hang - Why we can disable it (kernel will turn on it? or totally not needed?)
For example (I don't know the details so this is only for reference):
The CPU input gating is blah blah blah and needs a special driver to blah blah blah. The AP would hang without that. In firmware stage we don't need input gating but it was by default enabled so we have to disable it explicitly.
-
Hung-Te Lin (Code Review)