Change in coreboot[master]: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
DaLao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/ CLOVER/ACPI/1600x900-EDID/DSDT.edid-2e2-hs.dsl LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/ blob/master/vanilla%20ACPI%20dsl's/DSDT.dsl LEN0068
X230: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/ blob/master/DSDT/DSDT.dsl LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: dalao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/x230/Kconfig 6 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/1
diff --git a/src/ec/lenovo/h8/Kconfig b/src/ec/lenovo/h8/Kconfig index 6bd290f..2ea4faa 100644 --- a/src/ec/lenovo/h8/Kconfig +++ b/src/ec/lenovo/h8/Kconfig @@ -44,4 +44,11 @@ bool default n
+config THINKPADEC_HKEY_EISAID + string + default "IBM0068" + help + Motherboards of newer thinkpad models can override the default to match + vendor drivers and quirks. + endif # EC_LENOVO_H8 diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index eb49511..126c9ce 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -21,7 +21,7 @@ External (\HKBL, IntObj) External (\HUWB, IntObj)
- Name (_HID, EisaId ("IBM0068")) + Name (_HID, EisaId (CONFIG_THINKPADEC_HKEY_EISAID))
Name (BTN, 0)
diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index 7c715ed..0d7444d 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -75,4 +75,7 @@ string default "8086,0126"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif # BOARD_LENOVO_T420 diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index 009377d..d4415a1 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -68,4 +68,8 @@ config USBDEBUG_HCD_INDEX int default 2 + +config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif diff --git a/src/mainboard/lenovo/t440p/Kconfig b/src/mainboard/lenovo/t440p/Kconfig index 95cb1dc..f5f8db7 100644 --- a/src/mainboard/lenovo/t440p/Kconfig +++ b/src/mainboard/lenovo/t440p/Kconfig @@ -70,4 +70,7 @@ bool default n
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index b25d7cf..7dcbae0 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -75,4 +75,7 @@ string default "8086,0166"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" if BOARD_LENOVO_X230 + endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230T
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#2).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
X230: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: dalao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/x230/Kconfig 6 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/2
Prasun Gera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 2:
I can confirm LEN0068 for T530.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#3).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T530: Confirmed by Prasun Gera LEN0068
X230: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: dalao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 7 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/3
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#4).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T530: Confirmed by Prasun Gera LEN0068
X230: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: dalao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 7 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/4
DaLao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 4:
Patch Set 2:
I can confirm LEN0068 for T530.
Thank you, T530 is added in now.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 4:
(1 comment)
T520 and W520 also have the LEN0068 ID
https://review.coreboot.org/c/coreboot/+/40128/4/src/mainboard/lenovo/t530/K... File src/mainboard/lenovo/t530/Kconfig:
https://review.coreboot.org/c/coreboot/+/40128/4/src/mainboard/lenovo/t530/K... PS4, Line 89: default "LEN0068" if BOARD_LENOVO_T530 i can confirm that the W530 also uses LEN0068
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#5).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
X230: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: dalao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 27 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/5
DaLao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 5:
Patch Set 4:
(1 comment)
T520 and W520 also have the LEN0068 ID
Thank you. T520 and W520 have been added in.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#6).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
X230: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: dalao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/6
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/t530/K... File src/mainboard/lenovo/t530/Kconfig:
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/t530/K... PS6, Line 95: default "LEN0068" if BOARD_LENOVO_T530 From the acpidump output from the Linux kernel bug tracker [1], after `acpixtract` and `iasl -d *dat` this seems to be the same value for the Lenovo W530.
$ grep LEN0 *dsl dsdt.dsl: Name (_HID, EisaId ("LEN0078")) // _HID: Hardware ID dsdt.dsl: Name (_HID, EisaId ("LEN0068")) // _HID: Hardware ID
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=66731
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/x230/K... File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/x230/K... PS6, Line 85: default "LEN0068" if BOARD_LENOVO_X230 So you still need to verify the value for the `LENOVO_X230T`?
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#8).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: dalao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/8
DaLao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 8:
(2 comments)
Patch Set 6:
(2 comments)
Thank you and W530 and X230T has been added in.
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/t530/K... File src/mainboard/lenovo/t530/Kconfig:
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/t530/K... PS6, Line 95: default "LEN0068" if BOARD_LENOVO_T530
From the acpidump output from the Linux kernel bug tracker [1], after `acpixtract` and `iasl -d *dat […]
Done
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/x230/K... File src/mainboard/lenovo/x230/Kconfig:
https://review.coreboot.org/c/coreboot/+/40128/6/src/mainboard/lenovo/x230/K... PS6, Line 85: default "LEN0068" if BOARD_LENOVO_X230
So you still need to verify the value for the `LENOVO_X230T`?
OK, let's assume X230T has the same value.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 8: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40128/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40128/8//COMMIT_MSG@2 PS8, Line 2: Dalao Da Lao?
https://review.coreboot.org/c/coreboot/+/40128/8//COMMIT_MSG@42 PS8, Line 42: dalao Da Lao?
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#9).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/9
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#11).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/11
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#12).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/12
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#13).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/13
Da Lao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 13:
(2 comments)
Patch Set 8: Code-Review+1
(2 comments)
Thank you and these have been done.
https://review.coreboot.org/c/coreboot/+/40128/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40128/8//COMMIT_MSG@2 PS8, Line 2: Dalao
Da Lao?
Done
https://review.coreboot.org/c/coreboot/+/40128/8//COMMIT_MSG@42 PS8, Line 42: dalao
Da Lao?
Done
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#14).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/14
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#15).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/15
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 15:
@DaoLao can you rebase it so we can merge it?
Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 15: Code-Review+2
Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph, Swift Geek (Sebastian Grzywna),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40128
to look at the new patch set (#16).
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/40128/16
Da Lao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 16:
Patch Set 15:
@DaoLao can you rebase it so we can merge it?
Yes, it has been rebased.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 16: Code-Review+2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40128/4/src/mainboard/lenovo/t530/K... File src/mainboard/lenovo/t530/Kconfig:
https://review.coreboot.org/c/coreboot/+/40128/4/src/mainboard/lenovo/t530/K... PS4, Line 89: default "LEN0068" if BOARD_LENOVO_T530
i can confirm that the W530 also uses LEN0068
Done
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
ec/lenovo/h8: Config the ec hardware ids for newer thinkpads
Currently coreboot is using the ec hardware id IBM0068 for all thinkpads, but for newer thinkpads the id maybe LEN0068 or LEN0268. On Windows, the Lenovo Vantage app can't get battery details when using IBM0068. This patch config this id by motherboard. The hardware IDs for the following models can be found by searching for disassembled dsdt.asl on vendor BIOS: (But this info is not easy to find online. So I only changed some of the thinkpads.)
T420: https://github.com/tluck/Lenovo-T420-Clover/blob/master/EFI/CLOVER/ACPI/1600... LEN0068
T430: https://github.com/ThiagoSchetini/macosx-thinkpad-t430/blob/master/vanilla%2... LEN0068
T520: Confirmed by Patrick Rudolph LEN0068
W520: Confirmed by Patrick Rudolph LEN0068
T530: Confirmed by Prasun Gera LEN0068
W530: https://bugzilla.kernel.org/show_bug.cgi?id=66731 LEN0068
X230/X230T: https://github.com/tuandzung/ThinkPad-X230-macOS-10.12.x/blob/master/DSDT/DS... LEN0068
T440p: https://github.com/doudou/t440p/blob/master/acpi/2.30/dsdt.dsl LEN0068
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: I797080ec8ba7ce39d47fe587319f8f32d6938875 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40128 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/acpi/thinkpad.asl M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x230/Kconfig 8 files changed, 26 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/ec/lenovo/h8/Kconfig b/src/ec/lenovo/h8/Kconfig index 6bd290f..2ea4faa 100644 --- a/src/ec/lenovo/h8/Kconfig +++ b/src/ec/lenovo/h8/Kconfig @@ -44,4 +44,11 @@ bool default n
+config THINKPADEC_HKEY_EISAID + string + default "IBM0068" + help + Motherboards of newer thinkpad models can override the default to match + vendor drivers and quirks. + endif # EC_LENOVO_H8 diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index 0b8ca15..eca0d44 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -8,7 +8,7 @@ External (\HKBL, IntObj) External (\HUWB, IntObj)
- Name (_HID, EisaId ("IBM0068")) + Name (_HID, EisaId (CONFIG_THINKPADEC_HKEY_EISAID))
Name (BTN, 0)
diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index dfc8ed1..182ca46 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -81,4 +81,7 @@ config PS2M_EISAID default "LEN0015"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif # BOARD_LENOVO_T420 diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index 45c7ae3..6139452 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -75,4 +75,7 @@ config PS2M_EISAID default "LEN0015"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif diff --git a/src/mainboard/lenovo/t440p/Kconfig b/src/mainboard/lenovo/t440p/Kconfig index e678548..7310dc1 100644 --- a/src/mainboard/lenovo/t440p/Kconfig +++ b/src/mainboard/lenovo/t440p/Kconfig @@ -76,4 +76,7 @@ config PS2M_EISAID default "LEN0036"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index aebb2dee..3529367 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -90,4 +90,7 @@ config PS2M_EISAID default "LEN0015"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 2a0e3ea..4dc77e9 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -91,4 +91,7 @@ config PS2M_EISAID default "LEN0015"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 37b264d..f134bc8 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -89,4 +89,7 @@ config PS2M_EISAID default "LEN0020"
+config THINKPADEC_HKEY_EISAID + default "LEN0068" + endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230T
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40128 )
Change subject: ec/lenovo/h8: Config the ec hardware ids for newer thinkpads ......................................................................
Patch Set 17:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3950 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3949 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3948 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3947
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Alexander Couzens (Code Review)
-
Da Lao (Code Review)
-
DaLao (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Prasun Gera (Code Review)