Change in coreboot[master]: soc/intel/elkhartlake: Add PSE TSN support - coreboot-gerrit

21 Dec 2021


      Attention is currently required from: Maulik V Vaghela, Paul Menzel, Mario Scheithauer, Angel Pons, Lean Sheng Tan, Patrick Rudolph.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56633 )
Change subject: soc/intel/elkhartlake: Add PSE TSN support
......................................................................
Patch Set 26:
(1 comment)
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56633/comment/8b27f561_79cecf68 
PS26, Line 94: if (xtal_freq_enum != (XTAL_24_MHZ || XTAL_38_4_MHZ)) {
This is wrong here (XTAL_24_MHZ || XTAL_38_4_MHZ is always true).
It shouold be:
if ((xtal_freq_enum != XTAL_24_MHZ) && (xtal_freq_enum != XTAL_38_4_MHZ)) {
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56633
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3807ff5a4578be7b2c67064525fa5099950986a
Gerrit-Change-Number: 56633
Gerrit-PatchSet: 26
Gerrit-Owner: Lean Sheng Tan
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 21 Dec 2021 14:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment