Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31251 )
Change subject: mb/google/{hatch,sarien}: Configure GPIOs using cnl_configure_pads ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31251/1/src/mainboard/google/sarien/ramstage... File src/mainboard/google/sarien/ramstage.c:
https://review.coreboot.org/#/c/31251/1/src/mainboard/google/sarien/ramstage... PS1, Line 31: /* Workaround FSP issue by reprogramming GPIOs after FSP-S */ : static void mainboard_init(struct device *dev) : { : const struct pad_config *gpio_table; : size_t num_gpios; : : gpio_table = variant_gpio_table(&num_gpios); : gpio_configure_pads(gpio_table, num_gpios); : }
Should be able to kill this now.
Oops yeah. I had made the change, but never added it.