Attention is currently required from: Lance Zhao, Patrick Rudolph, Elyes Haouas, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 )
Change subject: treewide/Kconfig: Drop unused symbols ......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/62362/comment/7e6635cd_ddbaeb83 PS2, Line 104: : config INTEL_GMA_OPREGION_2_0 : bool : default n if INTEL_GMA_OPREGION_2_1 : default y
sorry I don't understand why it will affect drivers/intel/gma/opregion.c […]
Sure, but look at the way these two Kconfigs are structured; OPREGION_2_0 is the default, unless INTEL_GMA_OPREGION_2_1 is selected. soc/intel/alderlake/Kconfig selects OPREGION_2_1 and then https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... will change its behavior based on which of those two options is selected; they're intended to be mutually exclusive, you have to pick one or the other; 2.0 is the default, unless 2.1 is selected.
-
Tim Wawrzynczak (Code Review)