Attention is currently required from: Andrey Pronin, Paul Menzel, Christian Walter, Yu-Ping Wu.
Yi Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 )
Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()` ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71885/comment/35983642_62cf3801 PS2, Line 10: and
an?
Done
File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/71885/comment/3ef42c22_f00a8595 PS2, Line 84: /**
/*
Done
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/71885/comment/0c85d706_167f53d1 PS2, Line 504: /* Unknown handle, returned if the key doesn't exist. */
Is this comment for which switch case?
Done
File src/security/tpm/tss/tcg-2.0/tss_marshaling.c:
https://review.coreboot.org/c/coreboot/+/71885/comment/2718d236_7ae9ffee PS2, Line 550: "%s:%d - " : "size mismatch: expected %d, remaining %zd\n",
Can fit in one line.
Done
File src/security/tpm/tss/tcg-2.0/tss_structures.h:
https://review.coreboot.org/c/coreboot/+/71885/comment/ba137266_056759cd PS2, Line 149: RC_VER1
`RC_FMT1`
Done
https://review.coreboot.org/c/coreboot/+/71885/comment/33a305ee_ded6e437 PS2, Line 328: uint16_t size;
Is there a need to use a fixed-length data type, or could it be `unsigned int`?
The TPM2 spec said the type of size in TPM2B struct is `UINT16`.
https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part2_St...
-
Yi Chou (Code Review)