Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68795 )
Change subject: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68795/comment/f67ef922_8408e87e
PS4, Line 11: Tested:
everything works fine, except the touchpad toggle on Linux when udev entries are missing (see CB:687 […]
Could you mention that UCSI is not implemented?
File src/mainboard/clevo/cml-u/smihandler.c:
https://review.coreboot.org/c/coreboot/+/68795/comment/399af331_ff742a7d
PS4, Line 19: return 0;
probably not and even mainboard_smi_apmc could be void just like the other smi functions (except mai […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac401ada2945bb58fe862895458b10fed505fe
Gerrit-Change-Number: 68795
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:51:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment