Attention is currently required from: Karthik Ramasubramanian, Keith Short, Shelley Chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80308?usp=email )
Change subject: util/cbfstool: Fallback to linear search ......................................................................
Patch Set 2:
(1 comment)
File util/cbfstool/flashmap/fmap.c:
https://review.coreboot.org/c/coreboot/+/80308/comment/2e67ba0a_0aea0bc4 : PS1, Line 108: 16
My EC binary wasn't forcing alignment of FMAP and I ran into this. […]
Yeah that's a bit of a weird choice in the `flash_ec` script. `futility load_fmap` would probably make more sense there.
This change is definitely way less efficient than just changing the stride to something smaller (because then bsearch will only search the offsets it hasn't already searched at the smaller stride). But either way I'm not sure we should be changing cbfstool for a use case it wasn't meant for anyway.