Attention is currently required from: Frank Wu, John Su, Dtrain Hsu, Eric Lai, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73489 )
Change subject: spd/lp5: Add new memory part to LP5 list
......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73489/comment/829b2e06_a26ed6e0
PS5, Line 7: Add new memory part to LP5 list
More specific: Add 2 Micron memory parts
https://review.coreboot.org/c/coreboot/+/73489/comment/cc7572f2_f417ea1c
PS5, Line 9: MICRON
Micron
https://review.coreboot.org/c/coreboot/+/73489/comment/2f1326cf_05dc60a7
PS5, Line 10: data sheets
Please add the names and revisions.
https://review.coreboot.org/c/coreboot/+/73489/comment/7a158300_3fbec5f2
PS5, Line 11: using the newly added parts
That’s redundant.
https://review.coreboot.org/c/coreboot/+/73489/comment/65ac4123_cabf9740
PS5, Line 11: SoC
the SoC
File spd/lp5/memory_parts.json:
https://review.coreboot.org/c/coreboot/+/73489/comment/b816d0cc_f6bfd774
PS5, Line 222: {
Tabs and spaces seem to be mixed. Maybe add a commit before fixing this for the old entries too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Gerrit-Change-Number: 73489
Gerrit-PatchSet: 5
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 07 Mar 2023 06:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment