Change in coreboot[master]: driver/spi: Drop HAVE_SMI_HANDLER dependency

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34195 )

Change subject: driver/spi: Drop HAVE_SMI_HANDLER dependency
......................................................................

driver/spi: Drop HAVE_SMI_HANDLER dependency

TBD: evaluate situation

Change-Id: I620d3ce5aa9632d862d6480922144f002cf6423b
Signed-off-by: Kyösti Mälkki 
---
M src/drivers/spi/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/34195/1

diff --git a/src/drivers/spi/Kconfig b/src/drivers/spi/Kconfig
index b15a502..983f9cd 100644
--- a/src/drivers/spi/Kconfig
+++ b/src/drivers/spi/Kconfig
@@ -63,7 +63,6 @@

config SPI_FLASH_SMM
    bool
-	depends on HAVE_SMI_HANDLER
    help
      Select this option if you want SPI flash support in SMM.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34195 )

Change subject: driver/spi: Drop HAVE_SMI_HANDLER dependency
......................................................................

Patch Set 1:

I suppose this is needed for the `select ELOG...` in
`src/vendorcode/google/chromeos/Kconfig`. I don't know
how it works on non-x86 platforms, on x86, this should
probably be disabled `if !HAVE_SMI_HANDLER`? Or should
`config CHROMEOS` select `HAVE_SMI_HANDLER`?

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34195 )

Change subject: driver/spi: Drop HAVE_SMI_HANDLER dependency
......................................................................

Patch Set 1:

I think all this really does is removes SPI_FLASH_SMM from .config. Remeber, with HAVE_SMI_HANDLER we do not even build the smm-class this SPI feature would be built into.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34195 )

Change subject: driver/spi: Drop HAVE_SMI_HANDLER dependency
......................................................................

Patch Set 1:
> I think all this really does is removes SPI_FLASH_SMM from .config. Remeber, with HAVE_SMI_HANDLER we do not even build the smm-class this SPI feature would be built into.

Well, but then you have features selected that you don't get.
I'd prefer to have that visible in config / errors on conflicts.

Change in coreboot[master]: drivers/elog: Fix ELOG_GSMI dependency

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34195

to look at the new patch set (#2).

Change subject: drivers/elog: Fix ELOG_GSMI dependency
......................................................................

drivers/elog: Fix ELOG_GSMI dependency

SMM_TSEG is a qualifier between TSEG and ASEG only, while
HAVE_SMI_HANDLER currently tells if SMM will be installed.

Move rest of the file under same 'if ELOG' block.

Change-Id: I620d3ce5aa9632d862d6480922144f002cf6423b
Signed-off-by: Kyösti Mälkki 
---
M src/drivers/elog/Kconfig
1 file changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/34195/2

Change in coreboot[master]: drivers/elog: Fix ELOG_GSMI dependency

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34195 )

Change subject: drivers/elog: Fix ELOG_GSMI dependency
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: drivers/elog: Fix ELOG_GSMI dependency

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34195 )

Change subject: drivers/elog: Fix ELOG_GSMI dependency
......................................................................

drivers/elog: Fix ELOG_GSMI dependency

SMM_TSEG is a qualifier between TSEG and ASEG only, while
HAVE_SMI_HANDLER currently tells if SMM will be installed.

Move rest of the file under same 'if ELOG' block.

Change-Id: I620d3ce5aa9632d862d6480922144f002cf6423b
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34195
Reviewed-by: Furquan Shaikh 
Tested-by: build bot (Jenkins) 
---
M src/drivers/elog/Kconfig
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/drivers/elog/Kconfig b/src/drivers/elog/Kconfig
index da8a5fa..4a66e78 100644
--- a/src/drivers/elog/Kconfig
+++ b/src/drivers/elog/Kconfig
@@ -42,10 +42,8 @@
    help
      This option will enable event logging from the preram stage.

-endif
-
 config ELOG_GSMI
-	depends on ELOG && SMM_TSEG
+	depends on HAVE_SMI_HANDLER
    bool "SMI interface to write and clear event log"
    select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP
    default n
@@ -55,7 +53,6 @@
      kernel reset/shutdown messages to the event log.

config ELOG_BOOT_COUNT
-	depends on ELOG
    bool "Maintain a monotonic boot number in CMOS"
    default n
    help
@@ -64,9 +61,11 @@
      counter will be logged as part of the System Boot event.

config ELOG_BOOT_COUNT_CMOS_OFFSET
-	depends on ELOG && ELOG_BOOT_COUNT && !USE_OPTION_TABLE
+	depends on ELOG_BOOT_COUNT && !USE_OPTION_TABLE
    int "Offset in CMOS to store the boot count"
    default 0
    help
      This value must be greater than 16 bytes so as not to interfere
      with the standard RTC region.  Requires 8 bytes.
+
+endif