Attention is currently required from: Keith Short, Tim Wawrzynczak, Nick Vaccaro.
Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50111 )
Change subject: mb/google/volteer: update thermal table for Eldrid
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50111/comment/9b13e501_f692d93f
PS1, Line 104: 60.8
This will turn into `60` (it's an unsigned int type), did you mean 60?
I mean 60.8 but turn into 60 is ok.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f1fe9a6de4dbb587b79cb8758c5458a3ae5d768
Gerrit-Change-Number: 50111
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Attention: Keith Short
keithshort@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 01:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment