Change in coreboot[master]: soc/amd/picasso: Add .acpi_name and .acpi_fill_ssdt_generator for ACP...
Hello Aaron Durbin,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42969
to review the following change.
Change subject: soc/amd/picasso: Add .acpi_name and .acpi_fill_ssdt_generator for ACP device ......................................................................
soc/amd/picasso: Add .acpi_name and .acpi_fill_ssdt_generator for ACP device
This change adds support for .acpi_name and .acpi_fill_ssdt_generator device operations for the ACP device.
BUG=b:157603026
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I84bb8150dada99def85b685535706aa609de227f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Commit-Queue: Furquan Shaikh furquan@chromium.org Tested-by: Furquan Shaikh furquan@chromium.org Reviewed-by: Aaron Durbin adurbin@google.com --- M src/soc/amd/picasso/acp.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/42969/1
diff --git a/src/soc/amd/picasso/acp.c b/src/soc/amd/picasso/acp.c index 29b7521..1e871e9 100644 --- a/src/soc/amd/picasso/acp.c +++ b/src/soc/amd/picasso/acp.c @@ -35,12 +35,19 @@ sb_clk_output_48Mhz(); /* Internal connection to I2S */ }
+static const char *acp_acpi_name(const struct device *dev) +{ + return "ACPD"; +} + static struct device_operations acp_ops = { .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = init, .ops_pci = &pci_dev_ops_pci, + .acpi_name = acp_acpi_name, + .acpi_fill_ssdt = acpi_device_write_pci_dev, };
static const struct pci_driver acp_driver __pci_driver = {
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42969 )
Change subject: soc/amd/picasso: Add .acpi_name and .acpi_fill_ssdt_generator for ACP device ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42969 )
Change subject: soc/amd/picasso: Add .acpi_name and .acpi_fill_ssdt_generator for ACP device ......................................................................
soc/amd/picasso: Add .acpi_name and .acpi_fill_ssdt_generator for ACP device
This change adds support for .acpi_name and .acpi_fill_ssdt_generator device operations for the ACP device.
BUG=b:157603026
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I84bb8150dada99def85b685535706aa609de227f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Commit-Queue: Furquan Shaikh furquan@chromium.org Tested-by: Furquan Shaikh furquan@chromium.org Reviewed-by: Aaron Durbin adurbin@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42969 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/picasso/acp.c 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/soc/amd/picasso/acp.c b/src/soc/amd/picasso/acp.c index 29b7521..1e871e9 100644 --- a/src/soc/amd/picasso/acp.c +++ b/src/soc/amd/picasso/acp.c @@ -35,12 +35,19 @@ sb_clk_output_48Mhz(); /* Internal connection to I2S */ }
+static const char *acp_acpi_name(const struct device *dev) +{ + return "ACPD"; +} + static struct device_operations acp_ops = { .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = init, .ops_pci = &pci_dev_ops_pci, + .acpi_name = acp_acpi_name, + .acpi_fill_ssdt = acpi_device_write_pci_dev, };
static const struct pci_driver acp_driver __pci_driver = {
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)