Attention is currently required from: Angel Pons, Arthur Heymans, Eric Lai, Felix Held, Felix Singer, Kyösti Mälkki, Raul Rangel, Tim Wawrzynczak.
Hello Angel Pons, Arthur Heymans, Eric Lai, Felix Held, Felix Singer, Kyösti Mälkki, Raul Rangel, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76090?usp=email
to look at the new patch set (#4).
Change subject: allocator_v4: Fix top-level allocations w/o IORESOURCE_ABOVE_4G ......................................................................
allocator_v4: Fix top-level allocations w/o IORESOURCE_ABOVE_4G
When moving the code to allocate at the top level in commit 9260ea60bfa4 (allocator_v4: Use memranges only for toplevel), a call to restrict the limit of the resource was dropped. Probably by accident in one of the earliest rebases. Without this call to effective_limit(), 64-bit resour- ces at the top level, i.e. PCI bus 0, were always placed above 4G. Even when this was not requested with the IORESOURCE_ABOVE_4G flag.
Tested on kontron/ktqm77 where the issue could be reproduced with x86_64. Without the fix, boot hangs when trying to access the GMA MMIO registers of PCI 00:02.0, which were placed above 4G.
Change-Id: Ied3a0695ef5e91f092bf2d442c1c482057643483 Signed-off-by: Nico Huber nico.h@gmx.de Found-by: 9elements QA --- M src/device/resource_allocator_v4.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/76090/4